From a56d6b568bfe9aac30f65fdeabad3635b6b938f5 Mon Sep 17 00:00:00 2001 From: Ulric Qin Date: Thu, 30 Dec 2021 09:37:52 +0800 Subject: [PATCH] refactor log print --- src/server/writer/writer.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/server/writer/writer.go b/src/server/writer/writer.go index 58e1acca..195224e8 100644 --- a/src/server/writer/writer.go +++ b/src/server/writer/writer.go @@ -3,6 +3,7 @@ package writer import ( "bytes" "context" + "fmt" "net" "net/http" "time" @@ -44,6 +45,10 @@ type WriterType struct { } func (w WriterType) Write(items []*prompb.TimeSeries) { + if len(items) == 0 { + return + } + req := &prompb.WriteRequest{ Timeseries: items, } @@ -56,6 +61,7 @@ func (w WriterType) Write(items []*prompb.TimeSeries) { if err := w.Post(snappy.Encode(nil, data)); err != nil { logger.Warningf("post to %s got error: %v", w.Opts.Url, err) + logger.Warning("example timeseries:", items[0].String()) } } @@ -82,7 +88,7 @@ func (w WriterType) Post(req []byte) error { } if resp.StatusCode >= 400 { - logger.Warningf("push data with remote write request got status code: %v, response body: %s", resp.StatusCode, string(body)) + err = fmt.Errorf("push data with remote write request got status code: %v, response body: %s", resp.StatusCode, string(body)) return err }