Merge branch 'szzh' of http://repository.trustie.net/xianbo/trustie2 into szzh

.gitignore

@@ -22,3 +22,4 @@
 .DS_Store
 public/api_doc/
 /.metadata
+vendor/cache

Gemfile

@@ -1,5 +1,4 @@
-source 'http://rubygems.org'
-#source 'http://ruby.taobao.com'
+source 'http://ruby.taobao.org'
 #source 'http://ruby.sdutlinux.org/'
 
 unless RUBY_PLATFORM =~ /w32/
@@ -11,11 +10,11 @@ end
 
 gem 'grape', '~> 0.9.0'
 gem 'grape-entity'
-gem 'seems_rateable', path: 'lib/seems_rateable'
+gem 'seems_rateable', '~> 1.0.13'
 gem "rails", "3.2.13"
 gem "jquery-rails", "~> 2.0.2"
 gem "i18n", "~> 0.6.0"
-gem "coderay", "~> 1.0.6"
+gem 'coderay', '~> 1.1.0'
 gem "fastercsv", "~> 1.5.0", :platforms => [:mri_18, :mingw_18, :jruby]
 gem "builder", "3.0.0"
 gem 'acts-as-taggable-on', '2.4.1'
@@ -28,11 +27,16 @@ gem 'rails_kindeditor'
 group :development do
   gem 'grape-swagger'
   #gem 'grape-swagger-ui', git: 'https://github.com/guange2015/grape-swagger-ui.git'
-  #gem 'puma'
+  gem 'puma' if RbConfig::CONFIG['host_os'] =~ /linux/
   gem 'pry-rails'
-  gem 'pry-byebug'
-  gem 'better_errors', path: 'lib/better_errors'
-  gem 'rack-mini-profiler', path: 'lib/rack-mini-profiler'
+  if RUBY_VERSION >= '2.0.0'
+    gem 'pry-byebug'
+  else
+    gem 'pry-debugger'
+  end
+  gem 'pry-stack_explorer'
+  gem 'better_errors', '~> 1.1.0'
+  gem 'rack-mini-profiler', '~> 0.9.3'
 end
 
 group :test do

app/controllers/courses_controller.rb

@@ -873,13 +873,15 @@ class CoursesController < ApplicationController
         "show_course_news" => true,
         "show_course_messages" => true,
         "show_bids" => true,
-        "show_course_journals_for_messages" => true
+        "show_course_journals_for_messages" => true,
+        "show_homeworks" => true
     }
     @date_to ||= Date.today + 1
     #
     @date_from = (@date_to - @days) > @course.created_at.to_date ? (@date_to - @days) : @course.created_at.to_date
     #@date_from = @date_to - @days-1.years
     @author = (params[:user_id].blank? ? nil : User.active.find(params[:user_id]))
+    @author ||= @course.teacher
     # 决定显示所用用户或单个用户活动
     @activity = Redmine::Activity::Fetcher.new(User.current, :course => @course,
                                                :with_subprojects => false,

app/controllers/git_callback_controller.rb

@@ -0,0 +1,9 @@
+class GitCallbackController < ApplicationController
+
+  def post_update
+    @repository = Repository.find_by_root_url(params[:root_url])
+    @repository.fetch_changesets
+    render :text => 'success'
+  end
+
+end

app/controllers/issues_controller.rb

@@ -58,7 +58,7 @@ class IssuesController < ApplicationController
 
   def index
     retrieve_query
-    sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
+    sort_init(@query.sort_criteria.empty? ? [['updated_on', 'desc']] : @query.sort_criteria)
     sort_update(@query.sortable_columns)
     @query.sort_criteria = sort_criteria.to_a
 
@@ -381,7 +381,7 @@ class IssuesController < ApplicationController
   def retrieve_previous_and_next_issue_ids
     retrieve_query_from_session
     if @query
-      sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
+      sort_init(@query.sort_criteria.empty? ? [['updated_on', 'desc']] : @query.sort_criteria)
       sort_update(@query.sortable_columns, 'issues_index_sort')
       limit = 500
       issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])

app/controllers/members_controller.rb

@@ -109,7 +109,7 @@ class MembersController < ApplicationController
         end
         if params[:flag]
           unless members.present? && members.all? {|m| m.valid? }
-            flash[:error] = members.collect {|m| m.errors.full_messages}.flatten.uniq.join(', ')
+            flash[:error] = members.empty? ? l(:label_user_role_null) :members.collect {|m| m.errors.full_messages}.flatten.uniq.join(', ')
           else
             flash[:notice] = l(:label_invite_success)
           end

app/controllers/projects_controller.rb

@@ -340,6 +340,7 @@ class ProjectsController < ApplicationController
       @is_zhuce =false
       flash[:notice] = l(:notice_email_sent, :value => email)
     else
+      flash[:error] = l(:notice_registed_success, :value => email)
       @is_zhuce = true
     end
     respond_to do |format|

app/controllers/repositories_controller.rb

@@ -92,6 +92,22 @@ class RepositoriesController < ApplicationController
     render :action => 'show', :layout => 'base_projects'
   end
 
+
+  HOOK_TEMPLATE = %Q{#!/bin/sh
+exec sh -c '
+function update()
+{
+        CMD_PATH=`dirname $0`;
+        cd $CMD_PATH;
+        PY_PATH=$PWD/../../git_refresh_changes.py;
+        [[ -s "$PY_PATH"   ]] && $(which python) $PY_PATH $PWD;
+        cd -;
+}
+git update-server-info
+update
+'
+  }
+
   def create
     if params[:repository_scm].to_s == 'Gitlab'
       # add by nwb
@@ -127,7 +143,6 @@ class RepositoriesController < ApplicationController
       if attrs[:attrs_extra].keys.any?
         @repository.merge_extra_info(attrs[:attrs_extra])
       end
-      #by xianbo
 
       @repository.project = @project
       if request.post? && @repository.save
@@ -145,12 +160,11 @@ class RepositoriesController < ApplicationController
                      "</Limit> \n ' >> "+
                      @root_path+"htdocs/"+ @repository_name+"/.htaccess"
           system "cd "+@project_path+" ;git update-server-info"
-          # if(create_repo_file&&create_passwd&&create_group&&init_repository&&add_privilege&&init_server_info)
-          # else
-          # logger.info "An error occured when authenticating "+"create passwd"+@creat_passwd+"create_group"+
-          # crate_group+"create repository file "+create_repo_file+"init repository"+init_repostory+
-          # "aad privilege to rpository"+add_privilege+"init server infos"+init_server_info
-          # end
+
+          File.open(@project_path+"/hooks/post-update", "w+") do |f|
+            f.write(HOOK_TEMPLATE)
+          end
+
           @repository.update_attributes(:login => User.current.login.to_s)
         end
         redirect_to settings_project_url(@project, :tab => 'repositories')
@@ -160,6 +174,8 @@ class RepositoriesController < ApplicationController
              render :action => 'new', :layout =>'base_projects'
            end
       end
+
+
     end
   end
   

app/controllers/users_controller.rb

@@ -445,15 +445,15 @@ class UsersController < ApplicationController
       else
         activity = Activity.where(where_condition).where('user_id = ?', @user.id).order('id desc')
       end
-      activity = activity.reject { |e|
-            e.act.nil? ||
-            (!User.current.admin? && !e.act.nil?
-            (((e.act_type == "Issue") && !e.act.project.visible?(User.current)) ||
-                (e.act_type == "Bid" && !e.act.courses.first.nil? && e.act.courses.first.is_public == 0 && !User.current.member_of_course?(e.act.courses.first)) ||
-                (e.act_type == "Journal" && e.act.respond_to?("Project") && !e.act.project.visible?(User.current)) ||
-                (e.act_type == "News" && ((!e.act.project.nil? && !e.act.project.visible?(User.current)) || (!e.act.course.nil? && e.act.course.is_public == 0 && !User.current.member_of_course?(e.act.course)))) ||
-                (e.act_type == "Message" && !e.act.board.nil? && ((!e.act.board.project.nil? && !e.act.board.project.visible?(User.current)) || (!e.act.board.course.nil? && e.act.board.course.is_public == 0 && !User.current.member_of_course?(e.act.board.course))))))
-      }
+      # activity = activity.reject { |e|
+      #       e.act.nil? ||
+      #       (!User.current.admin? && !e.act.nil?
+      #       (((e.act_type == "Issue") && !e.act.project.visible?(User.current)) ||
+      #           (e.act_type == "Bid" && !e.act.courses.first.nil? && e.act.courses.first.is_public == 0 && !User.current.member_of_course?(e.act.courses.first)) ||
+      #           (e.act_type == "Journal" && e.act.respond_to?("Project") && !e.act.project.visible?(User.current)) ||
+      #           (e.act_type == "News" && ((!e.act.project.nil? && !e.act.project.visible?(User.current)) || (!e.act.course.nil? && e.act.course.is_public == 0 && !User.current.member_of_course?(e.act.course)))) ||
+      #           (e.act_type == "Message" && !e.act.board.nil? && ((!e.act.board.project.nil? && !e.act.board.project.visible?(User.current)) || (!e.act.board.course.nil? && e.act.board.course.is_public == 0 && !User.current.member_of_course?(e.act.board.course))))))
+      # }
       @activity_count = activity.count
       @activity_pages = Paginator.new @activity_count, pre_count, params['page']
       @activity = activity.slice(@activity_pages.offset,@activity_pages.per_page)

app/helpers/application_helper.rb

@@ -1994,4 +1994,10 @@ module ApplicationHelper
     end
     technical_title
   end
+
+
+  def ie8?
+    request.env["HTTP_USER_AGENT"] =~ /MSIE 8.0/
+  end
+
 end

app/helpers/watchers_helper.rb

@@ -43,7 +43,7 @@ module WatchersHelper
     )
     method = watched ? 'delete' : 'post'
   
-    link_to text, url, :remote => true, :method => method, :style => "color: #fff; display:block; padding: 0px 5px; margin-right: 10px; height: 22px; line-height: 22px; background: none repeat scroll 0% 0% #64BDD9; TES"
+    link_to text, url, :remote => true, :method => method, :style => "color: #fff; display:block; padding: 0px 5px; margin-right: 10px; height: 22px; line-height: 21px;padding-top:1px; background: none repeat scroll 0% 0% #64BDD9; TES"
   end
   
   ############## added by linchun  
@@ -278,11 +278,11 @@ module WatchersHelper
     )
     method = applied ? 'delete' : 'post'
 
-    link_to text, url, :remote => true, :method => method ,:style => "color: #fff; display:block; padding: 0px 5px; margin-right: 10px; height: 22px; line-height: 22px; background: none repeat scroll 0% 0% #64BDD9; TES"
+    link_to text, url, :remote => true, :method => method ,:style => "color: #fff; display:block; padding: 0px 5px; margin-right: 10px; height: 21px; line-height: 22px;padding-top:1px; background: none repeat scroll 0% 0% #64BDD9; TES"
   end
 
     def exit_project_link(project)
       link_to(l(:label_exit_project),exit_cur_project_path(project.id),
-        :remote => true, :confirm => l(:lable_sure_exit_project), :style => "color: #fff; display:block; padding: 0px 5px; margin-right: 10px; height: 22px; line-height: 22px; background: none repeat scroll 0% 0% #64BDD9; TES" )
+        :remote => true, :confirm => l(:lable_sure_exit_project), :style => "color: #fff; display:block; padding: 0px 5px; margin-right: 10px; height: 21px; line-height: 22px; background: none repeat scroll 0% 0% #64BDD9; TES;padding-top:1px;" )
     end
   end

app/models/bid.rb

@@ -61,14 +61,21 @@ class Bid < ActiveRecord::Base
     end
   }
 
+  scope :course_visible, lambda {|*args|
+                         includes(:courses).where(Course.allowed_to_condition(args.shift || User.current, :view_homeworks, *args))
+                       }
+
   acts_as_watchable
   acts_as_taggable
 
-  acts_as_event :title => Proc.new {|o| "#{l(:label_requirement)} ##{o.id}: #{o.name}" },
+  acts_as_event :title => Proc.new {|o| "#{l(:label_course_homework)} ##{o.id}: #{o.name}" },
                 :description => :description,
                 :author => :author,
                 :url => Proc.new {|o| {:controller => 'bids', :action => 'show', :id => o.id}}
 
+  acts_as_activity_provider :type => 'homeworks',
+                            :author_key => :author_id
+
   acts_as_activity_provider :find_options => {:include => [:projects, :author]},
                             :author_key => :author_id
 

app/models/user.rb

@@ -778,7 +778,7 @@ class User < Principal
         (block_given? ? yield(role, self) : true)
       }
       #添加课程相关的权限判断
-     elsif context && context.is_a?(Course)
+    elsif context && context.is_a?(Course)
         return false unless context.allows_to?(action)
         # Admin users are authorized for anything else
         return true if admin?

app/models/user_extensions.rb

@@ -32,40 +32,42 @@ class UserExtensions < ActiveRecord::Base
   def get_brief_introduction
      return self.brief_introduction
   end
-  
+
+
 # added by meng
   def show_identity
-    if self.identity == 0
-      if User.current.language == 'zh'
-        user_identity = '教师'
-      else
-        user_identity = 'Teacher'
-      end
-    elsif self.identity == 1
-      if User.current.language == 'zh'
-        user_identity = '学生'
-      else
-        user_identity = 'Student'
-      end
-    elsif self.identity == 2
-      if User.current.language == 'zh'
-        user_identity = '企业'
-      else
-        user_identity = 'Enterprise'
-      end
-    elsif self.identity == 3
-      if User.current.language == 'zh'
-        user_identity = '开发者'
-      else
-        user_identity = 'Developer'
+    if User.current.language == 'zh'||User.current.language == ''
+      case self.identity
+        when 0
+          user_identity = l(:label_account_identity_teacher)
+        when 1
+          user_identity = l(:label_account_identity_student)
+        when 2
+          user_identity = l(:label_account_identity_enterprise)
+        when 3
+          user_identity = l(:label_account_identity_developer)
+        else
+          user_identity = ''
       end
     else
-      user_identity = ''
+      case self.identity
+        when 0
+          user_identity = l(:label_account_identity_teacher)
+        when 1
+          user_identity = l(:label_account_identity_student)
+        when 2
+          user_identity = l(:label_account_identity_enterprise)
+        when 3
+          user_identity = l(:label_account_identity_developer)
+        else
+          user_identity = ''
+       end
     end
     return user_identity
   end
-# end 
-  
+# end
+
+
   def self.introduction(user, message)
     unless user.user_extensions.nil?
        info = user.user_extensions

app/views/attachments/_form.html.erb

@@ -1,6 +1,6 @@
 <span id="attachments_fields" xmlns="http://www.w3.org/1999/html">
 <% if defined?(container) && container && container.saved_attachments %>
-  <% container.attachments.each_with_index do |attachment, i| %>
+  <% container.saved_attachments.each_with_index do |attachment, i| %>
     <span id="attachments_p<%= i %>" class="attachment">
       <%= text_field_tag("attachments[p#{i}][filename]", attachment.filename, :class => 'filename readonly', :readonly=>'readonly')%>
       <%= text_field_tag("attachments[p#{i}][description]", attachment.description, :maxlength => 254, :placeholder => l(:label_optional_description), :class => 'description', :style=>"display: inline-block;") %>
@@ -34,7 +34,6 @@
       <%= hidden_field_tag "attachments[p#{i}][token]", "#{attachment.token}" %>
     </span>
   <% end %>
-
 <% end %>
 </span>
 <script type='text/javascript'>
@@ -49,13 +48,13 @@
 <span class="add_attachment" style="font-weight:normal;">
     <%#= button_tag "浏览", :type=>"button", :onclick=>"CompatibleSend();" %>
     <!--%= link_to image_tag(),"javascript:void(0)", :onclick => "_file.click()"%-->
-    <%= button_tag "浏览", :type=>"button", :onclick=>"_file.click()",:onmouseover => 'this.focus()' %>
+    <%= button_tag l(:button_browse), :type=>"button", :onclick=>"_file.click()",:onmouseover => 'this.focus()', :style => ie8? ? 'display:none' : '' %>
     <%= file_field_tag 'attachments[dummy][file]',
           :id => '_file',
           :class => 'file_selector',
           :multiple => true,
           :onchange => 'addInputFiles(this);',
-          :style => 'display:none',
+          :style => ie8? ? '' : 'display:none',
           :data => {
             :max_file_size => Setting.attachment_max_size.to_i.kilobytes,
             :max_file_size_message => l(:error_attachment_too_big, :max_size => number_to_human_size(Setting.attachment_max_size.to_i.kilobytes)),

app/views/attachments/_form_course.html.erb

@@ -38,7 +38,7 @@
 <span class="add_attachment">
 <%#= button_tag "浏览", :type=>"button", :onclick=>"CompatibleSend();" %>
 <!--%= link_to image_tag(),"javascript:void(0)", :onclick => "_file.click()"%-->
-<%= button_tag "浏览", :type=>"button", :onclick=>"_file.click()" %>
+<%= button_tag l(:button_browse), :type=>"button", :onclick=>"_file.click()" %>
 <%= file_field_tag 'attachments[dummy][file]',
       :id => '_file',
       :class => 'file_selector',

app/views/attachments/destroy.js.erb

@@ -1,7 +1,7 @@
 $('#attachments_<%= j params[:attachment_id] %>').remove();
 var count=$('#attachments_fields>span').length;
 if(count<=0){
-	$("#upload_file_count").text("未上传文件");
+	$("#upload_file_count").text(<%= l(:label_no_file_uploaded)%>);
 	$(".remove_all").remove();
 }else{
     $("#upload_file_count").html("已上传"+"<span id=\"count\">"+count+"</span>"+"个文件");

app/views/files/_attachement_list.html.erb

@@ -22,13 +22,13 @@
 </span>
 </div>
 
-<button name="button" class="f_l ml10" onclick="_file.click()" onmouseover="this.focus()" type="button" style="width:20%; height:26%;"><%= l(:label_browse)%></button>
+<button name="button" class="f_l ml10" onclick="_file.click()" onmouseover="this.focus()" type="button" style="<%= ie8? ? 'display:none' : '' %>; width:20%; height:26%;"><%= l(:label_browse)%></button>
 <%= file_field_tag 'attachments[dummy][file]',
                    :id => '_file',
                    :class => 'file_selector',
                    :multiple => true,
                    :onchange => 'addInputFiles(this);',
-                   :style => 'display:none',
+                   :style => ie8? ? '': 'display:none',
                    :data => {
                            :max_file_size => Setting.attachment_max_size.to_i.kilobytes,
                            :max_file_size_message => l(:error_attachment_too_big, :max_size => number_to_human_size(Setting.attachment_max_size.to_i.kilobytes)),

app/views/files/_new.html.erb

@@ -8,10 +8,10 @@
   <table>
     <tr>
       <% if versions.any? %>
-          <td><p><%= l(:field_version) %></p></td>
+          <td><p style="padding-left: 50px;"><%= l(:field_version) %></p></td>
           <td>
             <%= select_tag "version_id", content_tag('option', '') +
-                    options_from_collection_for_select(versions, "id", "name"), {style: 'width:100px'} %>
+                    options_from_collection_for_select(versions, "id", "name"), {style: 'width:230px'} %>
           </td>
           <% if attachmenttypes.any? %>
               <td><%= l(:attachment_type) %></label></td>
@@ -31,14 +31,10 @@
             <% end %>
           </p>
       <% end %>
-
     </tr>
   </table>
-
-
+  <p style="padding-left: 54px;"> <%=l(:label_attachment_plural)%></label><%= render :partial => 'attachments/form', locals: {project: project} %></p>
   </p>
-
-<p><%=l(:label_attachment_plural)%></label><%= render :partial => 'attachments/form', locals: {project: project} %></p>
 </div>
 <%= submit_tag l(:button_add) %>
 <% end %>

app/views/files/_upload_show.html.erb

@@ -4,7 +4,8 @@
     <div class="upload_box">
       <%= error_messages_for 'attachment' %>
       <div id="network_issue" style="color: red; display: none;"><%= l(:label_file_upload_error_messages)%></div>
-      <%= form_tag(course_files_path(course), :multipart => true,:remote => true,:method => :post,:name=>"upload_form") do %>
+
+      <%= form_tag(course_files_path(course), :multipart => true,:remote => !ie8?,:name=>"upload_form") do %>
           <!-- <label style="margin-top:3px;"><#%= l(:label_file_upload)%></label>   -->
           <%= render :partial => 'attachement_list',:locals => {:course => course} %>
           <div class="cl"></div>

app/views/issues/_action_menu.html.erb

@@ -12,7 +12,7 @@
 
 <% end %>
 
-<%= watcher_link(@issue, User.current) %>
+
 <%= link_to l(:button_copy), project_copy_issue_path(@project, @issue), :class => 'icon icon-copy' if User.current.allowed_to?(:add_issues, @project) %>
 <%= link_to l(:button_delete), issue_path(@issue.id), :data => {:confirm => issues_destroy_confirmation_message(@issue)}, :method => :delete, :class => 'icon icon-del' if User.current.allowed_to?(:delete_issues, @project) %>
 </div>