From 370dcf7654e85351a6fc882f0adce44278df1a8a Mon Sep 17 00:00:00 2001 From: hedaoyuan Date: Thu, 10 Aug 2017 21:46:42 +0800 Subject: [PATCH] Add a todo in the nnpack function, when groups > 1 and batchSize > 1. --- paddle/function/nnpack/NNPACKConvOp.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/paddle/function/nnpack/NNPACKConvOp.cpp b/paddle/function/nnpack/NNPACKConvOp.cpp index 00d048eb21..c9f1ddcd92 100644 --- a/paddle/function/nnpack/NNPACKConvOp.cpp +++ b/paddle/function/nnpack/NNPACKConvOp.cpp @@ -196,10 +196,13 @@ public: CHECK_EQ(status, nnp_status_success); } } else { + // only supports stride = 1 + CHECK_EQ(strideH(), 1); + CHECK_EQ(strideW(), 1); + + // TODO(hedaoyuan): There has some bug when batchSize > 1 and groups_ > 1. + CHECK_EQ(groups_, (size_t)1); for (size_t g = 0; g < groups_; g++) { - // only supports stride = 1 - CHECK_EQ(strideH(), 1); - CHECK_EQ(strideW(), 1); nnp_status status = nnp_convolution_output(algorithm_, batchSize,