for code review 5

8 years ago · 3fbff1ee78
parent 350cc61f3f
commit 3fbff1ee78
3 changed files with 7 additions and 0 deletions
--- a/paddle/operators/math/maxouting.cc
+++ b/paddle/operators/math/maxouting.cc
@ -89,6 +89,7 @@ public:
              if (input_data[input_idx] == output_data[output_idx]) {
                input_grad_data[input_idx] += output_grad_data[output_idx];
                continue_match = false;
+                break;
              }
          }
        }
--- a/paddle/operators/math/maxouting.cu
+++ b/paddle/operators/math/maxouting.cu
@ -65,6 +65,7 @@ __global__ void KernelMaxoutGrad(
        if (input_data[data_idx + g * feat_len] == output_data[i]) {
          max_index = data_idx + g * feat_len;
          continue_match = false;
+          break;
        }
      }
      if (max_index != -1) {
--- a/paddle/operators/maxout_op.cu.cc
+++ b/paddle/operators/maxout_op.cu.cc
@ -17,6 +17,11 @@
 namespace ops = paddle::operators;
 REGISTER_OP_GPU_KERNEL(maxout, ops::MaxOutKernel<paddle::platform::GPUPlace,
                       float>);
+REGISTER_OP_GPU_KERNEL(maxout, ops::MaxOutKernel<paddle::platform::GPUPlace,
+                       double>);
 REGISTER_OP_GPU_KERNEL(maxout_grad,
                       ops::MaxOutGradKernel<paddle::platform::GPUPlace,
                       float>);
+REGISTER_OP_GPU_KERNEL(maxout_grad,
+                       ops::MaxOutGradKernel<paddle::platform::GPUPlace,
+                       double>);