@ -468,6 +468,7 @@ function assert_api_spec_approvals() {
"paddle/fluid/framework/ir/node.h"
"paddle/fluid/framework/ir/graph.h"
"paddle/fluid/framework/framework.proto"
"python/requirements.txt"
"python/paddle/fluid/compiler.py"
"python/paddle/fluid/__init__.py"
"paddle/fluid/operators/distributed/send_recv.proto.in" )
@ -476,7 +477,7 @@ function assert_api_spec_approvals() {
echo " checking ${ API_FILE } change, PR: ${ GIT_PR_ID } , changes: ${ API_CHANGE } "
if [ " ${ API_CHANGE } " ] && [ " ${ GIT_PR_ID } " != "" ] ; then
# NOTE: per_page=10000 should be ok for all cases, a PR review > 10000 is not human readable.
# approval_user_list: XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,jacquesqiao 3048612,xsrobin 50069408 qingqing01 7845005 .
# approval_user_list: XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,jacquesqiao 3048612,xsrobin 50069408 ,qingqing01 7845005,junjun315 3124479 .
if [ " ${ API_FILE } " = = "paddle/fluid/API.spec" ] ; then
APPROVALS = ` curl -H " Authorization: token ${ GITHUB_API_TOKEN } " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${ GIT_PR_ID } /reviews?per_page= 10000 | \
python ${ PADDLE_ROOT } /tools/check_pr_approval.py 2 50069408 46782768 30176695 6836917 7845005`
@ -490,6 +491,9 @@ function assert_api_spec_approvals() {
elif [ " ${ API_FILE } " = = "python/paddle/fluid/__init__.py" ] ; then
APPROVALS = ` curl -H " Authorization: token ${ GITHUB_API_TOKEN } " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${ GIT_PR_ID } /reviews?per_page= 10000 | \
python ${ PADDLE_ROOT } /tools/check_pr_approval.py 1 50069408`
elif [ " ${ API_FILE } " = = "python/requirements.txt" ] ; then
APPROVALS = ` curl -H " Authorization: token ${ GITHUB_API_TOKEN } " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${ GIT_PR_ID } /reviews?per_page= 10000 | \
python ${ PADDLE_ROOT } /tools/check_pr_approval.py 1 3124479`
else
APPROVALS = ` curl -H " Authorization: token ${ GITHUB_API_TOKEN } " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${ GIT_PR_ID } /reviews?per_page= 10000 | \
python ${ PADDLE_ROOT } /tools/check_pr_approval.py 1 21351065 3048612 46782768 30176695 12538138 6836917 32832641`
@ -500,6 +504,8 @@ function assert_api_spec_approvals() {
echo " You must have one RD (chengduoZH or XiaoguangHu01 or qingqing01 or luotao1) and one PM (xsrobin) approval for the api change! ${ API_FILE } for the management reason of API interface and API document. "
elif [ " ${ API_FILE } " = = "CMakeLists.txt" ] ; then
echo " You must have one RD (luotao1 or chengduoZH or XiaoguangHu01) approval for the cmakelist change! ${ API_FILE } for the management reason of the Compilation parameter. "
elif [ " ${ API_FILE } " = = "python/requirements.txt" ] ; then
echo " You must have junjun315 approval for the python/requirements.txt change! ${ API_FILE } for the management reason of the Compilation parameter. "
elif [ " ${ API_FILE } " = = "python/paddle/fluid/__init__.py" ] ; then
echo " You must have xsrobin approval for the python/paddle/fluid/__init__.py change! ${ API_FILE } for the management reason of the environment variables. "
else