refine GetOrCreateVariable

8 years ago · 5e8d8e073b
parent 2f47562df8
commit 5e8d8e073b
1 changed files with 10 additions and 8 deletions
--- a/paddle/framework/scope.cc
+++ b/paddle/framework/scope.cc
@ -34,15 +34,17 @@ Variable* Scope::GetVariable(const std::string &name) const {
 }

 Variable* Scope::GetOrCreateVariable(const std::string &name) {
-  Variable* var;
-  var = GetVariable(name);
-  if (var == nullptr) {
-    auto err = CreateVariable(name);
-    if (!err.isOK()) {
-      return nullptr;
-    }
+  Variable* var = GetVariable(name);
+  if (var != nullptr) {
+    return var;
+  }
+
+  Error err = CreateVariable(name);
+  if (!err.isOK()) {
+    return nullptr;
+  } else {
+    return GetVariable(name);
  }
-  return GetVariable(name);
 }

 bool Scope::HaveVariable(const std::string &name) {