address pr comment

7 years ago · a5feb77159
parent 19e5c24f00
commit a5feb77159
2 changed files with 482 additions and 359 deletions
--- a/paddle/math/float16.h
+++ b/paddle/math/float16.h
--- a/paddle/math/tests/test_float16.cpp
+++ b/paddle/math/tests/test_float16.cpp
@ -55,10 +55,12 @@ TEST(float16, conversion_cpu) {
  EXPECT_EQ(float16(false).x, 0x0000);

  // Implicit conversion to and from Eigen::half
+  /*
  Eigen::half tmp = float16(1.0f);
  float16 v_conv = tmp;
  EXPECT_EQ(tmp.x, 0x3c00);
  EXPECT_EQ(v_conv.x, 0x3c00);
+  */

  // Default constructor
  float16 v_def;