Paddle

Commit Graph

Author	SHA1	Message	Date
Huihuang Zheng	00c8ee18ce	Fix test_cond flaky test under Windows (#24633 ) In the past, the test_cond will fail with 2% probability and easy to re-produce. Now I re-run 300 times and no failure occurs. The probability of still has the failure is (1 - 2%) ^ 300 ~= 0.00004. We can say the random failure disappears. Maybe someone fixed some bugs in PE.	5 years ago
Huihuang Zheng	1d3b0134ca	Error Message Enhancement (#23483 ) This PR enhances error messages of several API/OPs: ParallelExecutor (python && C++) Executor (python && C++) StaticRNN (python) IfElse (python) cond (python) split_lod_tensor (python && C++)	5 years ago
Huihuang Zheng	4c57e3951a	Temporary Disable Flaky test_cond Under Windows (#23424 ) The flaky windows test is hard to debug. It just has an exit code 0xc0000374 without any log so we don't know where and why. The probability of failure is about 1/50. I spent 3 days and found it happened only when using PE + control flow + Windows. Exit code 0xc0000374 indicates heap corruption or access violation, but I found the memory is enough during debugging. There is no failed test under 500+ linux tests. I suspect the reason is multiple thread difference between Windows and Linux but I don't have time to completely debug it now. I will temporary disable the test and fix it in next days.	5 years ago
songyouwei	b813c948f0	support control flow cond in dygraph mode (#22693 ) * dygraph support cond op test=develop * unittest coverage test=develop * fix coverage test=develop * fix for coverage test=develop * refine TypeError msg test=develop * remove restrict test=develop	6 years ago
Huihuang Zheng	dd4361568e	Add ParallelExecutor Test for Cond API and Fix PE Checks Shape Bug (#22029 )	6 years ago
Huihuang Zheng	557bce77da	Fix Backward Bugs in Conditional Block (#21809 ) The fixed bugs: 1. The condition sub-graph is not pruned 2. When backward graph is extremely simple, the whole backward ops are pruned.	6 years ago
Huihuang Zheng	1dcf6a7212	Add Much Complex Test and Fix Bugs for Control Flow cond API (#21532 ) Add tests to use dy/dx to make sure the gradient values calculated by the control flow backward is correct. Also fixed bugs detected by those tests. Fix bugs: 1. Unlike sum_op, optimizer ops don't allow uninitialized input tensor. But in conditional_block_grad_op, since the conditional_block may not run, the output gradient tensor may be uninitialized, which will cause the optimizer op error. To fix it, we should let optimizer ops support uninitialized input like sum_op or assign the uninitialized gradient to 0 when the conditional_block_grad_op doesn't run. I found there are about 10+ optimizer ops. To be simpler, I just assign output gradient of the conditional_block_grad_op to 0 in this PR. But it can be further explored whether we can make optimizer ops like sum_op to support uninitialized input tensor because theoretically we can speed up without the assigning in conditional_block_grad_op. 2. Infer parameter shapes during append_backward. I didn't know that all our parameters are in global block. When op_desc is inferring shapes at the sub-block, it may not know the shape of gradients of parameters whose shape information is at global block. I fixed it by inferring shapes of gradients from forward var. This PR also did some code clean up: 1. Print the var name when sgd_op catches shape error so that it is easier to debug 2. Fix a typo: dicta -> dict	6 years ago
Huihuang Zheng	630be31952	Fix Cond Bug for Nested Control Flow (#21340 ) * Commit before merging develop test=develop * Backup after working with Huihuang logs * Commit before deleting Huihuang debug loggings * Commit before debug test=develop * Fix bug commit test=develop * Backup of fixing bugs test=develop * Clean up code test=develop * Fix a bug in sum_op test=develop	6 years ago
Huihuang Zheng	e64d55f04e	Add basic Python Cond Layer (#21050 )	6 years ago

9 Commits (00c8ee18ce0ba2bdba75fe7f12b1d6be46fdedd0)