@ -503,13 +503,10 @@ function assert_api_spec_approvals() {
echo " checking ${ API_FILE } change, PR: ${ GIT_PR_ID } , changes: ${ API_CHANGE } "
echo " checking ${ API_FILE } change, PR: ${ GIT_PR_ID } , changes: ${ API_CHANGE } "
if [ " ${ API_CHANGE } " ] && [ " ${ GIT_PR_ID } " != "" ] ; then
if [ " ${ API_CHANGE } " ] && [ " ${ GIT_PR_ID } " != "" ] ; then
# NOTE: per_page=10000 should be ok for all cases, a PR review > 10000 is not human readable.
# NOTE: per_page=10000 should be ok for all cases, a PR review > 10000 is not human readable.
# approval_user_list: XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,xsrobin 50069408,qingqing01 7845005,junjun315 3124479,shanyi15 35982308 .
# approval_user_list: XiaoguangHu01 46782768,chengduoZH 30176695,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,tensor-tang 21351065,xsrobin 50069408,qingqing01 7845005,junjun315 3124479,shanyi15 35982308 ,guoshengCS 14105589,heavengate 12605721,kuke 3064195,Superjomn 328693,lanxianghit 47554610,cyj1986 39645414,hutuxian 11195205,frankwhzhang 20274488,nepeplwu 45024560 .
approval_line = ` curl -H " Authorization: token ${ GITHUB_API_TOKEN } " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${ GIT_PR_ID } /reviews?per_page= 10000`
approval_line = ` curl -H " Authorization: token ${ GITHUB_API_TOKEN } " https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${ GIT_PR_ID } /reviews?per_page= 10000`
if [ " ${ API_FILE } " = = "paddle/fluid/API.spec" ] ; then
if [ " ${ API_FILE } " = = "paddle/fluid/API.spec" ] ; then
APPROVALS = ` echo ${ approval_line } | python ${ PADDLE_ROOT } /tools/check_pr_approval.py 1 46782768 30176695 6836917 7845005`
APPROVALS = ` echo ${ approval_line } | python ${ PADDLE_ROOT } /tools/check_pr_approval.py 2 7534971 14105589 12605721 3064195 328693 47554610 39645414 11195205 20274488 45024560 `
if [ " ${ APPROVALS } " = = "TRUE" ] ; then
APPROVALS = ` echo ${ approval_line } | python ${ PADDLE_ROOT } /tools/check_pr_approval.py 1 50069408 35982308`
fi
elif [ " ${ API_FILE } " = = "CMakeLists.txt" ] ; then
elif [ " ${ API_FILE } " = = "CMakeLists.txt" ] ; then
APPROVALS = ` echo ${ approval_line } | python ${ PADDLE_ROOT } /tools/check_pr_approval.py 1 6836917 46782768 30176695`
APPROVALS = ` echo ${ approval_line } | python ${ PADDLE_ROOT } /tools/check_pr_approval.py 1 6836917 46782768 30176695`
elif [ " ${ API_FILE } " = = "python/paddle/fluid/__init__.py" ] ; then
elif [ " ${ API_FILE } " = = "python/paddle/fluid/__init__.py" ] ; then
@ -522,7 +519,7 @@ function assert_api_spec_approvals() {
echo " current pr ${ GIT_PR_ID } got approvals: ${ APPROVALS } "
echo " current pr ${ GIT_PR_ID } got approvals: ${ APPROVALS } "
if [ " ${ APPROVALS } " = = "FALSE" ] ; then
if [ " ${ APPROVALS } " = = "FALSE" ] ; then
if [ " ${ API_FILE } " = = "paddle/fluid/API.spec" ] ; then
if [ " ${ API_FILE } " = = "paddle/fluid/API.spec" ] ; then
echo " You must have one RD (chengduoZH or XiaoguangHu01 or qingqing01 or luotao1) and one PM (xsrobin ) approval for the api change! ${ API_FILE } for the management reason of API interface and API document. "
echo " You must have two RD (wanghaoshuang or guoshengCS or heavengate or kuke or Superjomn or lanxianghit or cyj1986 or hutuxian or frankwhzhang or nepeplwu ) approval for the api change! ${ API_FILE } for the management reason of API interface and API document. "
elif [ " ${ API_FILE } " = = "CMakeLists.txt" ] ; then
elif [ " ${ API_FILE } " = = "CMakeLists.txt" ] ; then
echo " You must have one RD (luotao1 or chengduoZH or XiaoguangHu01) approval for the cmakelist change! ${ API_FILE } for the management reason of the Compilation parameter. "
echo " You must have one RD (luotao1 or chengduoZH or XiaoguangHu01) approval for the cmakelist change! ${ API_FILE } for the management reason of the Compilation parameter. "
elif [ " ${ API_FILE } " = = "python/requirements.txt" ] ; then
elif [ " ${ API_FILE } " = = "python/requirements.txt" ] ; then