Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into optimize-pserver-profiler-thread-pool
test=developrevert-14324-fix_vlog
Qiao Longfei
7 years ago
commit
59fbfbfbf7
@ -0,0 +1,109 @@
|
|||||||
|
// Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
// you may not use this file except in compliance with the License.
|
||||||
|
// You may obtain a copy of the License at
|
||||||
|
//
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
//
|
||||||
|
// Unless required by applicable law or agreed to in writing, software
|
||||||
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
// See the License for the specific language governing permissions and
|
||||||
|
// limitations under the License.
|
||||||
|
|
||||||
|
#include "paddle/fluid/framework/details/sequential_execution_pass.h"
|
||||||
|
#include <string>
|
||||||
|
#include <unordered_map>
|
||||||
|
#include <unordered_set>
|
||||||
|
#include <vector>
|
||||||
|
#include "paddle/fluid/framework/op_proto_maker.h"
|
||||||
|
|
||||||
|
namespace paddle {
|
||||||
|
namespace framework {
|
||||||
|
namespace details {
|
||||||
|
|
||||||
|
static bool IsSameOpDesc(OpDesc *op1, OpDesc *op2) {
|
||||||
|
return op1->Type() == op2->Type() && op1->Inputs() == op2->Inputs() &&
|
||||||
|
op1->Outputs() == op2->Outputs();
|
||||||
|
}
|
||||||
|
|
||||||
|
std::unique_ptr<ir::Graph> SequentialExecutionPass::ApplyImpl(
|
||||||
|
std::unique_ptr<ir::Graph> graph) const {
|
||||||
|
// FIXME(zjl): Insert dependencies between some distributed ops may cause
|
||||||
|
// the multi_devices_graph_pass fails. So we skip these ops here.
|
||||||
|
// Indeed, maybe we should not insert dependencies between these ops
|
||||||
|
// casually, which may cause deadlock easily.
|
||||||
|
// We should add more skipped distributed ops when found errors in
|
||||||
|
// multi_devices_graph_pass
|
||||||
|
static std::unordered_set<std::string> skip_dist_ops{
|
||||||
|
"send", "recv", "send_barrier", "fetch_barrier"};
|
||||||
|
|
||||||
|
auto &ops = Get<const std::vector<OpDesc *>>(kAllOpDescs);
|
||||||
|
std::vector<ir::Node *> op_node_list;
|
||||||
|
op_node_list.reserve(ops.size());
|
||||||
|
|
||||||
|
std::unordered_map<ir::Node *, size_t> op_deps;
|
||||||
|
std::unordered_map<ir::Node *, std::unordered_set<ir::Node *>> pending_ops;
|
||||||
|
std::unordered_set<ir::Node *> ready_ops;
|
||||||
|
|
||||||
|
for (ir::Node *node : graph->Nodes()) {
|
||||||
|
if (!node->IsOp()) continue;
|
||||||
|
std::unordered_set<ir::Node *> preceding_ops;
|
||||||
|
for (auto *in : node->inputs) {
|
||||||
|
PADDLE_ENFORCE(in->IsVar(),
|
||||||
|
"Preceding Node of Op Nodes must be Var Node");
|
||||||
|
if (in->inputs.empty()) continue;
|
||||||
|
PADDLE_ENFORCE(in->inputs.size() == 1 && in->inputs[0]->IsOp(),
|
||||||
|
"Preceding Op Node of Var Node must be unique");
|
||||||
|
preceding_ops.insert(in->inputs[0]);
|
||||||
|
pending_ops[in->inputs[0]].insert(node);
|
||||||
|
}
|
||||||
|
op_deps[node] = preceding_ops.size();
|
||||||
|
if (preceding_ops.empty()) {
|
||||||
|
ready_ops.insert(node);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
for (auto *op_desc : ops) {
|
||||||
|
ir::Node *found_node = nullptr;
|
||||||
|
for (auto *node : ready_ops) {
|
||||||
|
if (IsSameOpDesc(op_desc, node->Op())) {
|
||||||
|
PADDLE_ENFORCE(found_node == nullptr,
|
||||||
|
"Found multiple op_desc in graph: %s", op_desc->Type());
|
||||||
|
found_node = node;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
PADDLE_ENFORCE_NOT_NULL(found_node, "Cannot find op_desc in graph: %s",
|
||||||
|
op_desc->Type());
|
||||||
|
for (auto *pending_op : pending_ops[found_node]) {
|
||||||
|
if (--op_deps.at(pending_op) == 0) {
|
||||||
|
ready_ops.insert(pending_op);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
ready_ops.erase(found_node);
|
||||||
|
if (skip_dist_ops.count(op_desc->Type()) == 0) {
|
||||||
|
op_node_list.push_back(found_node);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
for (size_t i = 1; i < op_node_list.size(); ++i) {
|
||||||
|
auto *dep_var = graph->CreateControlDepVar();
|
||||||
|
op_node_list[i]->inputs.push_back(dep_var);
|
||||||
|
op_node_list[i - 1]->outputs.push_back(dep_var);
|
||||||
|
dep_var->outputs.push_back(op_node_list[i]);
|
||||||
|
dep_var->inputs.push_back(op_node_list[i - 1]);
|
||||||
|
VLOG(10) << "Add dependencies between " << op_node_list[i - 1]->Name()
|
||||||
|
<< " and " << op_node_list[i]->Name();
|
||||||
|
}
|
||||||
|
return graph;
|
||||||
|
}
|
||||||
|
|
||||||
|
} // namespace details
|
||||||
|
} // namespace framework
|
||||||
|
} // namespace paddle
|
||||||
|
|
||||||
|
REGISTER_PASS(sequential_execution_pass,
|
||||||
|
paddle::framework::details::SequentialExecutionPass)
|
||||||
|
.RequirePassAttr(paddle::framework::details::kAllOpDescs);
|
||||||
@ -0,0 +1,34 @@
|
|||||||
|
// Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
// you may not use this file except in compliance with the License.
|
||||||
|
// You may obtain a copy of the License at
|
||||||
|
//
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
//
|
||||||
|
// Unless required by applicable law or agreed to in writing, software
|
||||||
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
// See the License for the specific language governing permissions and
|
||||||
|
// limitations under the License.
|
||||||
|
|
||||||
|
#pragma once
|
||||||
|
|
||||||
|
#include "paddle/fluid/framework/ir/graph.h"
|
||||||
|
#include "paddle/fluid/framework/ir/pass.h"
|
||||||
|
|
||||||
|
namespace paddle {
|
||||||
|
namespace framework {
|
||||||
|
namespace details {
|
||||||
|
|
||||||
|
constexpr char kAllOpDescs[] = "all_op_descs";
|
||||||
|
|
||||||
|
class SequentialExecutionPass : public ir::Pass {
|
||||||
|
protected:
|
||||||
|
std::unique_ptr<ir::Graph> ApplyImpl(
|
||||||
|
std::unique_ptr<ir::Graph> graph) const override;
|
||||||
|
};
|
||||||
|
|
||||||
|
} // namespace details
|
||||||
|
} // namespace framework
|
||||||
|
} // namespace paddle
|
||||||
@ -0,0 +1,58 @@
|
|||||||
|
/* Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
|
||||||
|
|
||||||
|
Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
you may not use this file except in compliance with the License.
|
||||||
|
You may obtain a copy of the License at
|
||||||
|
|
||||||
|
http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
|
||||||
|
Unless required by applicable law or agreed to in writing, software
|
||||||
|
distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
See the License for the specific language governing permissions and
|
||||||
|
limitations under the License. */
|
||||||
|
|
||||||
|
#include "paddle/fluid/framework/ir/depthwise_conv_mkldnn_pass.h"
|
||||||
|
#include "paddle/fluid/framework/ir/graph_pattern_detector.h"
|
||||||
|
|
||||||
|
namespace paddle {
|
||||||
|
namespace framework {
|
||||||
|
namespace ir {
|
||||||
|
|
||||||
|
#define GET_NODE(id, pattern) \
|
||||||
|
PADDLE_ENFORCE(subgraph.count(pattern.RetrieveNode(#id)), \
|
||||||
|
"pattern has no Node called %s", #id); \
|
||||||
|
auto* id = subgraph.at(pattern.RetrieveNode(#id)); \
|
||||||
|
PADDLE_ENFORCE_NOT_NULL(id, "subgraph has no node %s", #id);
|
||||||
|
|
||||||
|
std::unique_ptr<ir::Graph> DepthwiseConvMKLDNNPass::ApplyImpl(
|
||||||
|
std::unique_ptr<ir::Graph> graph) const {
|
||||||
|
PADDLE_ENFORCE(graph.get());
|
||||||
|
FusePassBase::Init("depthwise_conv_mkldnn_pass", graph.get());
|
||||||
|
GraphPatternDetector gpd;
|
||||||
|
|
||||||
|
auto* pattern = gpd.mutable_pattern();
|
||||||
|
pattern->NewNode("depthwise_conv")
|
||||||
|
->assert_is_op("depthwise_conv2d")
|
||||||
|
->assert_op_attr("use_mkldnn", true);
|
||||||
|
|
||||||
|
int found_depthwise_conv_mkldnn_count = 0;
|
||||||
|
auto handler = [&](const GraphPatternDetector::subgraph_t& subgraph,
|
||||||
|
Graph* g) {
|
||||||
|
VLOG(3) << "handle DepthwiseConvMKLDNN fuse";
|
||||||
|
GET_NODE(depthwise_conv, (*pattern));
|
||||||
|
depthwise_conv->Op()->SetType("conv2d");
|
||||||
|
found_depthwise_conv_mkldnn_count++;
|
||||||
|
};
|
||||||
|
|
||||||
|
gpd(graph.get(), handler);
|
||||||
|
AddStatis(found_depthwise_conv_mkldnn_count);
|
||||||
|
return graph;
|
||||||
|
}
|
||||||
|
|
||||||
|
} // namespace ir
|
||||||
|
} // namespace framework
|
||||||
|
} // namespace paddle
|
||||||
|
|
||||||
|
REGISTER_PASS(depthwise_conv_mkldnn_pass,
|
||||||
|
paddle::framework::ir::DepthwiseConvMKLDNNPass);
|
||||||
@ -0,0 +1,34 @@
|
|||||||
|
/* Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
|
||||||
|
|
||||||
|
Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
you may not use this file except in compliance with the License.
|
||||||
|
You may obtain a copy of the License at
|
||||||
|
|
||||||
|
http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
|
||||||
|
Unless required by applicable law or agreed to in writing, software
|
||||||
|
distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
See the License for the specific language governing permissions and
|
||||||
|
limitations under the License. */
|
||||||
|
|
||||||
|
#pragma once
|
||||||
|
|
||||||
|
#include "paddle/fluid/framework/ir/fuse_pass_base.h"
|
||||||
|
|
||||||
|
namespace paddle {
|
||||||
|
namespace framework {
|
||||||
|
namespace ir {
|
||||||
|
|
||||||
|
class DepthwiseConvMKLDNNPass : public FusePassBase {
|
||||||
|
public:
|
||||||
|
virtual ~DepthwiseConvMKLDNNPass() {}
|
||||||
|
|
||||||
|
protected:
|
||||||
|
std::unique_ptr<ir::Graph> ApplyImpl(
|
||||||
|
std::unique_ptr<ir::Graph> graph) const override;
|
||||||
|
};
|
||||||
|
|
||||||
|
} // namespace ir
|
||||||
|
} // namespace framework
|
||||||
|
} // namespace paddle
|
||||||
@ -0,0 +1,123 @@
|
|||||||
|
// Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved.
|
||||||
|
//
|
||||||
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
// you may not use this file except in compliance with the License.
|
||||||
|
// You may obtain a copy of the License at
|
||||||
|
//
|
||||||
|
// http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
//
|
||||||
|
// Unless required by applicable law or agreed to in writing, software
|
||||||
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
// See the License for the specific language governing permissions and
|
||||||
|
// limitations under the License.
|
||||||
|
|
||||||
|
#include "paddle/fluid/framework/ir/depthwise_conv_mkldnn_pass.h"
|
||||||
|
|
||||||
|
#include <gtest/gtest.h>
|
||||||
|
|
||||||
|
namespace paddle {
|
||||||
|
namespace framework {
|
||||||
|
namespace ir {
|
||||||
|
|
||||||
|
void SetOp(ProgramDesc* prog, const std::string& type, const std::string& name,
|
||||||
|
const std::vector<std::string>& inputs,
|
||||||
|
const std::vector<std::string>& outputs, bool use_mkldnn = false) {
|
||||||
|
auto* op = prog->MutableBlock(0)->AppendOp();
|
||||||
|
op->SetType(type);
|
||||||
|
op->SetAttr("use_mkldnn", use_mkldnn);
|
||||||
|
op->SetAttr("name", name);
|
||||||
|
op->SetInput("Input", {inputs[0]});
|
||||||
|
op->SetInput("Filter", {inputs[1]});
|
||||||
|
op->SetInput("Bias", {inputs[2]});
|
||||||
|
op->SetOutput("Out", outputs);
|
||||||
|
}
|
||||||
|
|
||||||
|
// (a, weights, bias)->depthwise conv mkldnn->b
|
||||||
|
// (b, weights2, bias2)->depthwise conv no mkldnn->c
|
||||||
|
// (c, weights3, bias3)->conv mkldnn->d
|
||||||
|
// (d, weights3, bias3)->conv no mkldnn->e
|
||||||
|
ProgramDesc BuildProgramDesc() {
|
||||||
|
ProgramDesc prog;
|
||||||
|
for (auto& v : std::vector<std::string>(
|
||||||
|
{"a", "b", "c", "d", "e", "weights", "bias", "weights2", "bias2",
|
||||||
|
"weights3", "bias3", "weights4", "bias4"})) {
|
||||||
|
auto* var = prog.MutableBlock(0)->Var(v);
|
||||||
|
var->SetType(proto::VarType::SELECTED_ROWS);
|
||||||
|
if (v == "weights" || v == "bias" || v == "weights2" || v == "bias2" ||
|
||||||
|
v == "weights3" || v == "bias3" || v == "weights4" || v == "bias4") {
|
||||||
|
var->SetPersistable(true);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// depthwise conv with MKL-DNN
|
||||||
|
SetOp(&prog, "depthwise_conv2d", "conv1",
|
||||||
|
std::vector<std::string>({"a", "weights", "bias"}),
|
||||||
|
std::vector<std::string>({"b"}), true);
|
||||||
|
// depthwise conv without MKL-DNN
|
||||||
|
SetOp(&prog, "depthwise_conv2d", "conv2",
|
||||||
|
std::vector<std::string>({"b", "weights2", "bias2"}),
|
||||||
|
std::vector<std::string>({"c"}), false);
|
||||||
|
// conv with MKL-DNN
|
||||||
|
SetOp(&prog, "conv2d", "conv3",
|
||||||
|
std::vector<std::string>({"c", "weights3", "bias3"}),
|
||||||
|
std::vector<std::string>({"d"}), true);
|
||||||
|
// conv without MKL-dNN
|
||||||
|
SetOp(&prog, "conv2d", "conv4",
|
||||||
|
std::vector<std::string>({"d", "weights4", "bias4"}),
|
||||||
|
std::vector<std::string>({"e"}), false);
|
||||||
|
|
||||||
|
return prog;
|
||||||
|
}
|
||||||
|
|
||||||
|
TEST(DepthwiseConvMKLDNNPass, basic) {
|
||||||
|
auto prog = BuildProgramDesc();
|
||||||
|
|
||||||
|
std::unique_ptr<ir::Graph> graph(new ir::Graph(prog));
|
||||||
|
|
||||||
|
auto pass = PassRegistry::Instance().Get("depthwise_conv_mkldnn_pass");
|
||||||
|
|
||||||
|
struct counters {
|
||||||
|
int mkldnn_depthwise_conv_nodes;
|
||||||
|
int other_depthwise_conv_nodes;
|
||||||
|
int mkldnn_conv_nodes;
|
||||||
|
int other_conv_nodes;
|
||||||
|
};
|
||||||
|
|
||||||
|
counters before{1, 1, 1, 1};
|
||||||
|
|
||||||
|
graph = pass->Apply(std::move(graph));
|
||||||
|
|
||||||
|
// initialize counters before loop
|
||||||
|
counters after{0, 0, 0, 0};
|
||||||
|
|
||||||
|
for (auto* node : graph->Nodes()) {
|
||||||
|
if (node->IsOp()) {
|
||||||
|
auto* op = node->Op();
|
||||||
|
if (op->Type() == "conv2d") {
|
||||||
|
if (boost::get<bool>(op->GetAttr("use_mkldnn")))
|
||||||
|
after.mkldnn_conv_nodes++;
|
||||||
|
else
|
||||||
|
after.other_conv_nodes++;
|
||||||
|
} else if (op->Type() == "depthwise_conv2d") {
|
||||||
|
if (boost::get<bool>(op->GetAttr("use_mkldnn")))
|
||||||
|
after.mkldnn_depthwise_conv_nodes++;
|
||||||
|
else
|
||||||
|
after.other_depthwise_conv_nodes++;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
EXPECT_EQ(after.other_depthwise_conv_nodes,
|
||||||
|
before.other_depthwise_conv_nodes);
|
||||||
|
EXPECT_EQ(after.other_conv_nodes, before.other_conv_nodes);
|
||||||
|
EXPECT_EQ(after.mkldnn_depthwise_conv_nodes,
|
||||||
|
before.mkldnn_depthwise_conv_nodes - 1);
|
||||||
|
EXPECT_EQ(after.mkldnn_conv_nodes, before.mkldnn_conv_nodes + 1);
|
||||||
|
}
|
||||||
|
|
||||||
|
} // namespace ir
|
||||||
|
} // namespace framework
|
||||||
|
} // namespace paddle
|
||||||
|
|
||||||
|
USE_PASS(depthwise_conv_mkldnn_pass);
|
||||||
Some files were not shown because too many files have changed in this diff Show More
Loading…
Reference in new issue