Revert "rename the default version from '0.0.0' to 'latest' (#17304)" (#17356)

This reverts commit f456c8beb8.
revert-17080-prepare_data
Jiabin Yang 6 years ago committed by GitHub
parent 8bae8590ac
commit c843e64cf5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -3,8 +3,6 @@ set(PADDLE_VERSION $ENV{PADDLE_VERSION})
set(tmp_version "HEAD") set(tmp_version "HEAD")
set(TAG_VERSION_REGEX "[0-9]+\\.[0-9]+\\.[0-9]+(\\.(a|b|rc)\\.[0-9]+)?") set(TAG_VERSION_REGEX "[0-9]+\\.[0-9]+\\.[0-9]+(\\.(a|b|rc)\\.[0-9]+)?")
set(COMMIT_VERSION_REGEX "[0-9a-f]+[0-9a-f]+[0-9a-f]+[0-9a-f]+[0-9a-f]+") set(COMMIT_VERSION_REGEX "[0-9a-f]+[0-9a-f]+[0-9a-f]+[0-9a-f]+[0-9a-f]+")
set(LATEST_PADDLE_VERSION "latest")
while ("${PADDLE_VERSION}" STREQUAL "") while ("${PADDLE_VERSION}" STREQUAL "")
# Check current branch name # Check current branch name
execute_process( execute_process(
@ -25,8 +23,8 @@ while ("${PADDLE_VERSION}" STREQUAL "")
if (${GIT_BRANCH_NAME} MATCHES "release/${TAG_VERSION_REGEX}") if (${GIT_BRANCH_NAME} MATCHES "release/${TAG_VERSION_REGEX}")
# Check the tag is a correct version # Check the tag is a correct version
if (${GIT_TAG_NAME} MATCHES "${COMMIT_VERSION_REGEX}") if (${GIT_TAG_NAME} MATCHES "${COMMIT_VERSION_REGEX}")
# if no tag was found, set PADDLE_VERSION to "latest" # if no tag was found, set PADDLE_VERSION to 0.0.0 to represent latest
set(PADDLE_VERSION "${LATEST_PADDLE_VERSION}") set(PADDLE_VERSION "0.0.0")
elseif (${GIT_TAG_NAME} MATCHES "v${TAG_VERSION_REGEX}") elseif (${GIT_TAG_NAME} MATCHES "v${TAG_VERSION_REGEX}")
string(REPLACE "v" "" PADDLE_VERSION ${GIT_TAG_NAME}) string(REPLACE "v" "" PADDLE_VERSION ${GIT_TAG_NAME})
else() # otherwise, get the previous git tag name. else() # otherwise, get the previous git tag name.
@ -44,19 +42,19 @@ while ("${PADDLE_VERSION}" STREQUAL "")
if (${GIT_EXACT_TAG_NAME} MATCHES "v${TAG_VERSION_REGEX}") if (${GIT_EXACT_TAG_NAME} MATCHES "v${TAG_VERSION_REGEX}")
string(REPLACE "v" "" PADDLE_VERSION ${GIT_EXACT_TAG_NAME}) string(REPLACE "v" "" PADDLE_VERSION ${GIT_EXACT_TAG_NAME})
else() else()
set(PADDLE_VERSION "${LATEST_PADDLE_VERSION}") set(PADDLE_VERSION "0.0.0")
endif() endif()
else() else()
# otherwise, we always set PADDLE_VERSION to "latest" # otherwise, we always set PADDLE_VERSION to 0.0.0 to represent latest
set(PADDLE_VERSION "${LATEST_PADDLE_VERSION}") set(PADDLE_VERSION "0.0.0")
endif() endif()
endif() endif()
else() else()
set(PADDLE_VERSION "${LATEST_PADDLE_VERSION}") set(PADDLE_VERSION "0.0.0")
message(WARNING "Cannot add paddle version from git tag") message(WARNING "Cannot add paddle version from git tag")
endif() endif()
else() else()
set(PADDLE_VERSION "${LATEST_PADDLE_VERSION}") set(PADDLE_VERSION "0.0.0")
message(WARNING "Cannot add paddle version for wrong git branch result") message(WARNING "Cannot add paddle version for wrong git branch result")
endif() endif()
endwhile() endwhile()

@ -30,14 +30,18 @@ class VersionTest(unittest.TestCase):
self._commit_regex = "[0-9a-f]{5,49}" self._commit_regex = "[0-9a-f]{5,49}"
def test_check_output(self): def test_check_output(self):
# check commit format
self.assertTrue(re.match(self._commit_regex, fluid_version.commit))
self.assertTrue(isinstance(fluid_version.istaged, bool)) self.assertTrue(isinstance(fluid_version.istaged, bool))
# check version format # check version format
if fluid_version.istaged: if fluid_version.istaged:
self.assertEqual(fluid_version.full_version, "latest") self.assertEqual(fluid_version.major, 0)
self.assertEqual(fluid_version.minor, 0)
self.assertEqual(fluid_version.patch, "0")
self.assertEqual(fluid_version.rc, 0)
self.assertEqual(fluid_version.full_version, "0.0.0")
else: else:
# check commit format
self.assertTrue(re.match(self._commit_regex, fluid_version.commit))
self.assertTrue(re.match(self._major_regex, fluid_version.major)) self.assertTrue(re.match(self._major_regex, fluid_version.major))
self.assertTrue(re.match(self._minor_regex, fluid_version.minor)) self.assertTrue(re.match(self._minor_regex, fluid_version.minor))
self.assertTrue(re.match(self._patch_regex, fluid_version.patch)) self.assertTrue(re.match(self._patch_regex, fluid_version.patch))

Loading…
Cancel
Save