Paddle

Commit Graph

Author	SHA1	Message	Date
Huihuang Zheng	649868ffb2	[Dy2stat] Fix the bug that loop_body_func may return single element (#31806 ) Our old `loop_body` function may return single element when `loop_vars` just contains only 1 element, which can cause bug. The key point of this PR is forcing `loop_body` functions always return tuple.	5 years ago
Aurelius84	def27bc801	[Dy2stat]Fix bug with static_convert_var_shape in locals scope (#31556 ) * Fix bug with static_convert_var_shape * replace dot with dash	5 years ago
Huihuang Zheng	6bf02a1261	[Dy2stat] Fix Read-Only Attribute as while_loop Output (#31415 ) Fix Read-Only Attribute as while_loop Output: Usually, our convert_while_loop will be like: ``` [a, b, c] = paddle.jit.dy2static.convert_while_loop( condition_name, body_name, [a, b, c]) ``` where a, b, c are in loop_var_names. However, if loop_var_names contains property such as foo.x, we cannot assign the attribute as output of convert_while_loop because Python property is a kind of read-only attribute. To handle the case, we replace the attributes which are output of convert_while_loop with generated variables, then if we know the attribute is not read-only at runtime, we assign the attribute. The created statements are like: ``` [a, b, __attribute_variable_1] = paddle.jit.dy2static.convert_while_loop( condition_name, body_name, [a, b, foo.x]) if not isinstance(getattr(type(foo), x, None), property): foo.x = __attribute_variable_1 ```	5 years ago
Aurelius84	1dd40870fc	[Dy2Stat] Fix eval_if_exist_else_none bug (#31261 ) * fix eval_if_exist_else_none bug * fix typo * fix typo * fix test_op_num unittest	5 years ago
Huihuang Zheng	cf43a321a8	[Dy2stat] Refactoring tensor_shape_transformer.py to Fix Change after Assign Bug (#31082 ) Problem In our old shape transformer logic, if user write: ``` s = tensor.shape ... y = paddle.some_api(s) ``` Dy2stat will change it to ``` ... y = paddle.some_api(convert_var_shape(tensor)) ``` However it will cause fatal bug if user changes the shape of `x` after assign. For example: ``` s = tensor.shape ... tensor = paddle.some_change_shape_api(tensor) ... y = paddle.some_api(s) ``` Then the Dy2stat will get wrong result because the code is translated into: ``` tensor = paddle.some_change_shape_api(tensor) ... y = paddle.some_api(convert_var_shape(tensor)) # tensor shape has been changed, not origin `s` value ``` Solution Logic It can not be solved in the old logic, so I refactoring tensor_shape_transformer logic. Now we will use `s` to store shape attribute and generate a var `s__STATIC_CONVERT_VAR_SHAPE_SUFFIX` to store static shape API `shape(tensor)` ``` s = tensor.shape ... y = paddle.some_api(s) ``` Dy2stat will change it to ``` s = tensor.shape s__STATIC_CONVERT_VAR_SHAPE_SUFFIX = shape(tensor) ... y = paddle.some_api(choose_shape_attr_or_api(s, s__STATIC_CONVERT_VAR_SHAPE_SUFFIX )) ``` In this case, the code is consistent with origin dygraph meaning and it fixed the change after assign bug. Code Key Note To help reviewers, the key change of this PR is changing `self.name_to_var_shape` from "mapping name to shape node" to "mapping name to its STATIC_CONVERT_VAR_SHAPE_SUFFIX name", then if a variable name has the SUFFIX, we can choose to use attribute shape or shape api. Other changes go with the key change. Consideration The issue of this PR is that we store extra static `shape` API result, will it harms the speed of Dy2stat? In some cases it will, but we argue that the benefit would be greater than the cost. 1. The extra calling to static `shape` API will happen when coder assign among shape variables. Take the following dygraph code as an instance: ``` s1 = tensor.shape s2 = s1 s3 = s2 ... ``` Then we called extra static `shape` APIs again and again, however users seldom write code like this. 2. If the shape variable is used a lot, for example: ``` s = tensor.shape y1 = paddle.some_api1(s) y2 = paddle.some_api2(s) y3 = paddle.some_api3(s) ``` Our old logic will create 3 shape APIs but now just 1. This is more common user code pattern. In fact, if reviewers take a look at the current unit test in this PR, you could see the op numbers decrease after this PR. So we argue that this PR can also improve speed in this code pattern.	5 years ago
Huihuang Zheng	ef627ac5b9	Fix that convert_var_shape doesn't support slice like [0:], test=develop (#31051 ) As the title, when slice_node like 1:3 being passed to idx of convert_var_shape, it will cause syntax error because a function cannot take this as argument. This PR fixed it.	5 years ago
Huihuang Zheng	c137578341	Add Support for Tuple in for Loop (#30998 ) Dy2stat didn't support tuple as iteration variable in the past. This PR added there main cases: 1). Non-enumerate case: for var1, var2 in var\|var.numpy() will be re-written as: for FOR_ITER_TUPLE_PREFIX_x in var \| var.numpy(): var1 = FOR_ITER_TUPLE_PREFIX_x[0] var2 = FOR_ITER_TUPLE_PREFIX_x[1] 2). Enumerate out tuple case: for t in enumerate(var\|var.numpy) will be rewritten as: for FOR_ITER_TUPLE_INDEX_PREFIX_x, FOR_ITER_TUPLE_PREFIX_x in enumerate(var\|var.numpy): t = (FOR_ITER_TUPLE_INDEX_PREFIX_x, FOR_ITER_TUPLE_PREFIX_x) 3). Enumerate inner tuple case: for i, (var1, (var2, va3)) in enumerate(var\|var.numpy()) will be re-written as: for i, FOR_ITER_TUPLE_PREFIX_x in var \| var.numpy(): var1 = FOR_ITER_TUPLE_PREFIX_x[0] var2 = FOR_ITER_TUPLE_PREFIX_x[1][0] var3 = FOR_ITER_TUPLE_PREFIX_x[1][1]	5 years ago
liym27	13ef444fa6	[Dy2Stat] Fix error message when the message has more than one lines. (#30714 )	6 years ago
Aurelius84	621bc4f771	[Dy2static]Fix paddle prefix in is_paddle_api (#30569 ) * add paddle. * add unittest	6 years ago
liym27	ff25c5b36f	Fix bug: GetAttrValue should deal with attr with attrType vector<double> (#30536 )	6 years ago
Huihuang Zheng	cd5f11b822	Decrease Batch Size for Windows CI, test=develop (#30331 ) As the title	6 years ago
Huihuang Zheng	017a534888	Decrease Mac Input Size Because of CI Short Memory (#30330 ) As the title	6 years ago
YUNSHEN XIE	42a6442a08	disable ut test_tsm on windows (#30017 ) * disable ut test_tsm on windows * fix error * add ut execuate time	6 years ago
Huihuang Zheng	c372a76303	Add Static Variable Clone (#30208 ) Add clone method for static Variable so that this interface will be same as dygraph. It fixed some bugs in dy2stat	6 years ago
Aurelius84	03e072736e	Skip convert tensor shape while using Paddle.shape (#30223 ) * fix tensor shape bug * fix op_num * clean code	6 years ago
liym27	ad55f609d5	[Dy2Stat] Don't convert to paddle.shape if var_x.shape is not negetive (#29965 ) 1. When x is Variable, call nn.shape(x) only in following cases: 1）The shape of x is used in control flow condition. 2）The dim to be used is negetive 2. When x is Variable, but x.shape or x.shape[idx] doesn't contain negetive value, don't convert to paddle.shape()	6 years ago
liym27	b2483d78a8	Fix test_slice: avoid unnecessary copying of TensorArray from subblock to parent block(#30168 ) In control flow, don't copy TensorArray from subblock to parent block when TensorArray is created in parent block.	6 years ago
liym27	97e75ad0f5	[setitem] Support Tensor setitem in static mode (#29708 ) 1. Type of index: int, slice(step must be 1). 2. Type of value: (1) int32, int64, float32, bool; (2) numpy.array(int32, int64, float32, bool);<Note: float64 is not supported> (3) paddle.Tensor(int32, int64, float32, float64, bool);	6 years ago
liym27	41a7b07159	[Dy2Stat] Fix bug for loop: a variable is used and created in loop, but used before created (#29769 )	6 years ago
liym27	a0b60716f1	[Dy2Stat] Support grammar: for ele in var[idx] (#29541 ) Support to transformfor ele in var stms in which var is a slice of Tensor.	6 years ago
liym27	096c048b45	Fix unitest test_slice (#29740 ) Before this commit, test_slice use old api `dygraph_to_static_func` to use Dynamic-t-Static and use Executor explicitly，which is not recommended to users. After fixed, use recommended API `paddle.jit.to_static` to replace `dygraph_to_static_func`, which won't trigger the random exception on coverage CI.	6 years ago
Huihuang Zheng	2e788bd81e	Reduce batch size ot fix CPU memory, test=develop (#29736 ) Unit test reported memory not enough on CPU machines. Reduce batch size again.	6 years ago
liym27	0cad1152f4	[Dy2Stat] 1. Fix bug of for-range stmts. 2. Support that step value is negative in for-range stmts (#29519 ) 1. Fix error in _build_cond_stmt of for-range stmts. 2. Support that step value is negative in for-range stmts 3. Fix code because of the diff between Py2 and Py3	6 years ago
Huihuang Zheng	831e9135b9	Fix Windows Unittest (#29543 ) Fix 3 Windows Unittests test_fuse_all_reduce_pass: Paddle cannot run multiple-GPU on Windows so set single visible GPU flag test_feed_data_check_shape_type: Paddle cannot run multiple-GPU on Windows so set single visible GPU flag test_tsm: Winodws GPU size is not enough so decrease batch size and data size.	6 years ago
GeminiCarrie	08f24a3108	Fix precision problem (#29567 ) * Fix a bug when running on an operating system without "bash." * add execution condition * for ci-coverage * get cpu information to check the precision problem * Update compilation environment for musl version * update dependencies * remove test code check cpu info remove test code review * update alpine and third_party denpendencies * add newline for ci Code format	6 years ago
Huihuang Zheng	8f7627907c	[Dy2stat] Reduce Exception Type for Better Error Message (#29268 ) Reduce exception type so that if covert_to_static failed, it reports right error message.	6 years ago
liym27	61a8f2874f	[Dy2Stat] Fix bug: Do not use gast.Subscript to replace gast.Name in when transforming for_enumerate_loop (#29310 )	6 years ago
liym27	b9a8ebd50f	[Dy2stat] Add a decorator paddle.jit.not_to_static to support that not to convert a function in Dynamic-to-Static. (#29253 ) Usage scenarios：A function could have run successfully in static mode, you can use it to decorate a function in the following cases: 1. An unknown error occurs in the dynamic-to-static conversion process of the function; 2. In the internal implementation of the function, it has two branches: dynamic branch and static branch; 3. Users don't want to convert the function in the process of dynamic to static.	6 years ago
Huihuang Zheng	aec05d811c	[Dy2stat] Fix PaddleGan Deoldify Model Dy2stat Problems (#29226 ) This PR fixes several problems in dy2stat for Deoldify model in PaddleGan. In model, software engineer wrote if x.shape == y.shape, the Tenser shape is a tuple in dygraph so the == returns True/False, but in static graph the == becomes element-wise comparison, which is a different behavior. In this PR we reduce the element-wise comparison result. If software engineer write computations which uses parameters in hooks, the static graph can loss the parameter variable because we put param_guard at forward of a Layer. In this PR we made param_guard cover pre-hook and post-hook. In PaddleGan, software engineer calculated some parameter values in __init__ by running some dygraph code. Those code also run during dy2stat. So some variables may be assign as a VarBase (Tensor) first and then Variable, which raised an error. We fixed the bug in this PR by handling the case. TODO: We just added testcase for the 1. shape comparison. Should add test case for 2. and 3. But since we are chasing 2.0RC, I will do it in the near future PR	6 years ago
Chen Weihang	786e69e9c7	diable test_yolov3 in musl (#29216 )	6 years ago
liym27	e03440812a	fix code: if y is True -> if y (#29184 )	6 years ago
Huihuang Zheng	27b4218333	[Dy2stat] Disable PaddleInference IR Optimization in test_mnist for CUDA11 (#29105 ) test_mnist failed on CUDA11. We found that it is due to PaddleInference IR Optimization after debugging. We disable it in this PR and we will re-enable it after PaddleInference fixes it.	6 years ago
liym27	01bdea7c31	[Dy2Stat] Don't conver the function from third library logging (#29161 )	6 years ago
liym27	a7433cc379	[Dy2Stat] Fix bug: the return statement should be transformed to an equivalent Paddle/Python if statement, which depends on if conditions of the return stmt. (#29165 )	6 years ago
Huihuang Zheng	4a0a870177	[dy2stat] Set shape for linspace to Fix dy2stat for GridGenerator Model (#29173 ) GridGenerator model failed because the output shape of `linspace` is (-1). The reason is that C++ InferShape fixes the shape to (-1): `5da3d514eb/paddle/fluid/operators/linspace_op.cc (L49)` We cannot set the shape in C++ infer shape because this Tensor may not be initialized during compile time, but when input `num` of `linspace` is an integer, we know the shape at compiler time. This PR simply set the shape in Python and add GridGenerator as unittest.	6 years ago
Aurelius84	cb680c8013	[Dy2Stat]Refine code of test_lac unittest (#29087 )	6 years ago
liym27	5fe44571f0	[Dynamic-to-Static] Support **kwargs as input of the function which is decorated by `jit.save.to_static` (#29098 )	6 years ago
YUNSHEN XIE	0fca8cdfdf	fix error with ut timeout and failed (#29148 )	6 years ago
Leo Chen	770395cb93	Split train_mode and has_grad for tracer (#29064 ) * split train_mode and has_grad * fix format * fix ci problems * fix sample code	6 years ago
liym27	682cc17f53	[Dynamic-to-Static] Fix bug: support pop from a dict and polish code of convert_pop (#29023 ) * Support pop for dict in dy2stat * Move convert_pop to convert_operators.py and polish convert_pop	6 years ago
Aurelius84	8af0d85ea4	fix unittest failed on windows GPU (#29072 )	6 years ago
tianshuo78520a	e9acd9c941	Update CI Python3 Docker for Cuda11 (#28401 )	6 years ago
Huihuang Zheng	5b339262bc	[Dy2stat] Add Tuple as Assign Target for Tensor Shape (#28775 ) Add support for using tuple as tensor.shape (For example: a, b, c, d = x.shape)	6 years ago
Leo Chen	3815d7aa40	Upgrade string literals to raw string (#28989 ) * upgrade comment string to raw string * fix string in * fix string with ' ' * revert update on comments * upgrade only necessary * fix sample code checker * fix comments with '''	6 years ago
liym27	85292e0b46	[Dynamic-to-Static] Fix bug of convert_logical_and/convert_logical_or: the operands are executed sequentially(#28993 ) 1) The operands are executed sequentially according to the running logic of Python. 2) If the left hand operand is True(for convert_logical_or)/False(for convert_logical_and), the right hand operand should be executed.	6 years ago
Huihuang Zheng	96126532cd	Fix Incorrect After Node Vars in IfElseTransformer, test=develop (#28992 ) The PR description is long. See details in the PR link.	6 years ago
Aurelius84	d6aee7597c	[Dy2Stat]Set buff.persistable=False when it's not initialized (#28749 )	6 years ago
Jack Zhou	9362d85e0e	Add LSTM, Simple RNN and GRU CPU kernel (#28577 ) * add lstm, simple rnn op kernel * fix the test_lstm for the rnn op * change func name * fix forward postprocess bug * add gru forward, backward code * remove unittest.skipIf; use a big rnn op instead of combination op * fix input doesn't have gradient bug * add eigen lstm forward, backward Co-authored-by: wawltor <fangzeyang0904@hotmail.com>	6 years ago
liym27	269470d62e	[Dynamic-to-Static] Remove unnecessary variables of the arguments in true_func/false_func (#28722 )	6 years ago
liym27	e5f0e6b003	[Dynamic-to-Static] Fix bug in loop_transformer: loop vars should contain the var from ancestor-for-node (#28735 )	6 years ago

1 2 3 4 5

227 Commits (develop)